<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"
	xmlns:content="http://purl.org/rss/1.0/modules/content/"
	xmlns:dc="http://purl.org/dc/elements/1.1/"
	xmlns:atom="http://www.w3.org/2005/Atom"
	xmlns:sy="http://purl.org/rss/1.0/modules/syndication/"
		>
<channel>
	<title>Comments on: Spring AOP timing aspect</title>
	<atom:link href="http://dhruba.name/2008/12/16/spring-aop-timing-aspect/feed/" rel="self" type="application/rss+xml" />
	<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/</link>
	<description>Maximum Zeal ~ Emphatic prose on indulged fascinations</description>
	<lastBuildDate>Fri, 27 Jan 2012 20:09:34 +0000</lastBuildDate>
	<sy:updatePeriod>hourly</sy:updatePeriod>
	<sy:updateFrequency>1</sy:updateFrequency>
	<generator>http://wordpress.org/?v=3.2.1</generator>
	<item>
		<title>By: Madhur Kumat Tanwani</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-10831</link>
		<dc:creator>Madhur Kumat Tanwani</dc:creator>
		<pubDate>Tue, 24 Nov 2009 14:26:16 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-10831</guid>
		<description>Just a note - since Java does not allow the @Inherited annotation, to actually meta data for methods, the aspect will not work on sub class beans. I dont know of a way to make that work (dont think its possible)</description>
		<content:encoded><![CDATA[<p>Just a note &#8211; since Java does not allow the @Inherited annotation, to actually meta data for methods, the aspect will not work on sub class beans. I dont know of a way to make that work (dont think its possible)</p>
]]></content:encoded>
	</item>
	<item>
		<title>By: Stefan F</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-3496</link>
		<dc:creator>Stefan F</dc:creator>
		<pubDate>Fri, 05 Jun 2009 15:51:28 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-3496</guid>
		<description>xml didn&#039;t work in my comment above. here&#039;s the code: http://snippets.dzone.com/posts/show/7423</description>
		<content:encoded><![CDATA[<p>xml didn&#8217;t work in my comment above. here&#8217;s the code: <a href="http://snippets.dzone.com/posts/show/7423" rel="nofollow">http://snippets.dzone.com/posts/show/7423</a></p>
]]></content:encoded>
	</item>
	<item>
		<title>By: Stefan F</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-3495</link>
		<dc:creator>Stefan F</dc:creator>
		<pubDate>Fri, 05 Jun 2009 15:48:58 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-3495</guid>
		<description>From http://static.springframework.org/spring/docs/2.5.x/reference/aop.html

6.3. Schema-based AOP support

&quot;Warning

The  style of configuration makes heavy use of Spring&#039;s auto-proxying mechanism. This can cause issues (such as advice not being woven) if you are already using explicit auto-proxying via the use of BeanNameAutoProxyCreator or suchlike. The recommended usage pattern is to use either just the  style, or just the AutoProxyCreator style.&quot;

So if you&#039;re already using  style, you&#039;ll have to add this advice the same way:

  
  
  	  
	  	  
	      
	  	  
	       
      
  </description>
		<content:encoded><![CDATA[<p>From <a href="http://static.springframework.org/spring/docs/2.5.x/reference/aop.html" rel="nofollow">http://static.springframework.org/spring/docs/2.5.x/reference/aop.html</a></p>
<p>6.3. Schema-based AOP support</p>
<p>&#8220;Warning</p>
<p>The  style of configuration makes heavy use of Spring&#8217;s auto-proxying mechanism. This can cause issues (such as advice not being woven) if you are already using explicit auto-proxying via the use of BeanNameAutoProxyCreator or suchlike. The recommended usage pattern is to use either just the  style, or just the AutoProxyCreator style.&#8221;</p>
<p>So if you&#8217;re already using  style, you&#8217;ll have to add this advice the same way:</p>
]]></content:encoded>
	</item>
	<item>
		<title>By: miluch</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-2417</link>
		<dc:creator>miluch</dc:creator>
		<pubDate>Thu, 16 Apr 2009 18:15:55 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-2417</guid>
		<description>hi

I found your blog and i really enjoy reading it.
I played with your aspect and it seems it can rewritten in a shorter form:

@Around(value = \@annotation(timed)\)
    static Object timeMethod(final ProceedingJoinPoint pjp, final Timed timed) throws Throwable {
        return time(pjp, timed);
    }

    @Around(\@target(timed)\)
    static Object timeClass(final ProceedingJoinPoint pjp, final Timed timed) throws Throwable {
        return time(pjp, timed);
    }
The next thing: 
testSampleServiceMethod2 method tests sampleServiceMethod1 but i suspect your intention was to test sampleServiceMethod2 instead. 

I wish Spring had a way to define pointcuts that could match annotations on superclasses and interfaces, but since annotations themselves are not inheritable ...</description>
		<content:encoded><![CDATA[<p>hi</p>
<p>I found your blog and i really enjoy reading it.<br />
I played with your aspect and it seems it can rewritten in a shorter form:</p>
<p>@Around(value = \@annotation(timed)\)<br />
    static Object timeMethod(final ProceedingJoinPoint pjp, final Timed timed) throws Throwable {<br />
        return time(pjp, timed);<br />
    }</p>
<p>    @Around(\@target(timed)\)<br />
    static Object timeClass(final ProceedingJoinPoint pjp, final Timed timed) throws Throwable {<br />
        return time(pjp, timed);<br />
    }<br />
The next thing:<br />
testSampleServiceMethod2 method tests sampleServiceMethod1 but i suspect your intention was to test sampleServiceMethod2 instead. </p>
<p>I wish Spring had a way to define pointcuts that could match annotations on superclasses and interfaces, but since annotations themselves are not inheritable &#8230;</p>
]]></content:encoded>
	</item>
	<item>
		<title>By: Dhruba Bandopadhyay</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-841</link>
		<dc:creator>Dhruba Bandopadhyay</dc:creator>
		<pubDate>Mon, 19 Jan 2009 22:26:07 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-841</guid>
		<description>George - I haven&#039;t tried it but it is very likely that it does work with annotated controllers for the simple reason that with annotated controllers all calls are public so go through the proxy whereas with the form controller hierarchy some calls were internal.  Try it and see!</description>
		<content:encoded><![CDATA[<p>George &#8211; I haven&#8217;t tried it but it is very likely that it does work with annotated controllers for the simple reason that with annotated controllers all calls are public so go through the proxy whereas with the form controller hierarchy some calls were internal.  Try it and see!</p>
]]></content:encoded>
	</item>
	<item>
		<title>By: George</title>
		<link>http://dhruba.name/2008/12/16/spring-aop-timing-aspect/comment-page-1/#comment-826</link>
		<dc:creator>George</dc:creator>
		<pubDate>Thu, 15 Jan 2009 02:10:35 +0000</pubDate>
		<guid isPermaLink="false">http://dhruba.name/?p=568#comment-826</guid>
		<description>You stated that  &quot;Cannot be applied on spring controller.&quot;  Does this apply to Spring 2.5 annotated controllers?</description>
		<content:encoded><![CDATA[<p>You stated that  &#8220;Cannot be applied on spring controller.&#8221;  Does this apply to Spring 2.5 annotated controllers?</p>
]]></content:encoded>
	</item>
</channel>
</rss>

